Skip to content

Comments

Rspamd/Rmilter update#14992

Merged
fpletz merged 8 commits intoNixOS:masterfrom
avnik:rspamd
May 1, 2016
Merged

Rspamd/Rmilter update#14992
fpletz merged 8 commits intoNixOS:masterfrom
avnik:rspamd

Conversation

@avnik
Copy link
Contributor

@avnik avnik commented Apr 25, 2016

Things done
  • Tested using sandboxing (nix-build --option build-use-sandbox true or nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

mention-bot commented Apr 25, 2016

By analyzing the blame information on this pull request, we identified @fpletz, @zimbatm and @rbvermaa to be potential reviewers

@avnik avnik changed the title Rspamd Rspamd/Rmilter update Apr 25, 2016
joachifm
joachifm reviewed Apr 26, 2016
View reviewed changes
nixos/modules/services/mail/rmilter.nix Outdated
Copy link
Contributor

@joachifm joachifm Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If socket activation is recommended, why make it optional?

Copy link
Contributor Author

@avnik avnik Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It recommended for domain socket setup, because rmilter (actually libmilter from sendmail) can't set proper permissions on socket.

So folks who prefer inet socket have option here.

@joachifm joachifm added 8.has: package (update) This PR updates a package to a newer version 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 26, 2016
avnik added 7 commits April 28, 2016 14:21
@avnik
rmilter: socket activation in nixos
c84c174
@avnik
rspamd: typo
5d26e80
@avnik
rmilter: correct paths to sockets
5c26039
@avnik
rspamd: configurable bindSocket and bindUISocket
36954ee
@avnik
libmemcached: move cyrus_sasl to propagatedBuildInputs
a817d5b 
Reason: struct/sasl.h from libmemcached include stuff from there
/nix/store/d3f91zvai71dyhs83ybzsnjfhxnv7mmh-libmemcached-1.0.18/include/libmemcached-1.0/struct/sasl.h:39:23:
fatal error: sasl/sasl.h: No such file or directory
@avnik
rmilter: 1.7.3 -> 1.8.2
ebdfc9d
@avnik
rspamd: 1.2.0 -> 1.2.5
0503634 
License changed to apache-2.0 by upstream
@avnik
Copy link
Contributor Author

avnik commented Apr 28, 2016

@joachifm I am corrected typo, also clarify statement about socket activation, which strongly recommended for unix domain sockets only

@joachifm
Copy link
Contributor

joachifm commented Apr 29, 2016

ping @zimbatm @fpletz does this look okay to you? I don't use this service and so would like an ack from someone who uses it before integrating the changes.

@fpletz
Copy link
Member

fpletz commented May 1, 2016

Thanks a lot! Works for me and looking good. 🍻

@fpletz fpletz merged commit 0276089 into NixOS:master May 1, 2016
@Centaurioun Centaurioun mentioned this pull request Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (update) This PR updates a package to a newer version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@avnik @mention-bot @joachifm @fpletz